Stubs and symbols for iTerm2#39
Merged
CuriousTommy merged 7 commits intodarlinghq:masterfrom Jun 19, 2024
Merged
Conversation
CuriousTommy
requested changes
Jun 16, 2024
CuriousTommy
left a comment
CuriousTommy
left a comment
There was a problem hiding this comment.
Other then the above issues, the code looks good to me!
CuriousTommy
requested changes
Jun 16, 2024
|
|
||
| #import <AppKit/NSTouchBarItem.h> | ||
|
|
||
| @interface NSCandidateListTouchBarItem<CandidateType> : NSTouchBarItem |
There was a problem hiding this comment.
On Apple's website, it's <__covariant CandidateType>
https://developer.apple.com/documentation/appkit/nscandidatelisttouchbaritem?language=objc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I attempted to get iTerm2 running under darling, these were the symbols/stubs I needed to implement in Cocotron. While I didn't manage to get iTerm2 fully running, I thought to push these up anyways.
Fixes specific missing symbol mentioned in: darlinghq/darling#1350
Stubs/Symbols Added