Merged
Conversation
Author
|
Lazerbeak12345
commented
May 15, 2025
Lazerbeak12345
force-pushed
the
apple-fonttools-fixes
branch
3 times, most recently
from
d6aa8bd to
6924cce
Compare
CuriousTommy
requested changes
May 16, 2025
CuriousTommy
left a comment
CuriousTommy
left a comment
There was a problem hiding this comment.
LGTM.
My only request is to get rid of the kCG... values. Unless there is proof that apps directly use those values, we shouldn't need to worry about implementing private internal values.
Lazerbeak12345
force-pushed
the
apple-fonttools-fixes
branch
from
6924cce to
319581f
Compare
Author
|
darlinghq/darling#805 is solely about those undocumented symbols, and I've marked this PR as no longer fixing them. |
CuriousTommy
requested changes
May 17, 2025
There was a problem hiding this comment.
The commit itself is good, I mostly have an issue with the commit message.
This has too much unnecessary details... Some of the messages can be combined into one.
several missing symbols
missing symbols required by MorxTester
fixes https://github.com/darlinghq/darling/issues/801
missing symbols required by fontworker,fontmover,FontRegistryUIAgent
no longer effects https://github.com/darlinghq/darling/issues/805
more missing symbols required by MorxTester
more symbols required by fontworker
remove undocumented symbols
Co-authored-by: Hin-Tak Leung <htl10@users.sourceforge.net>
When you combine commits, it's important to rewrite the commit message. Here is an example of how I would write your commit message:
Implement Missing Symbols Required By MorxTester
Taken from HinTak's original commits. Fixes darlinghq/darling#801
Co-authored-by: Hin-Tak Leung <htl10@users.sourceforge.net>
Taken from HinTak's original commits. Fixes darlinghq/darling#801 Co-authored-by: Hin-Tak Leung <htl10@users.sourceforge.net>
Lazerbeak12345
force-pushed
the
apple-fonttools-fixes
branch
from
319581f to
bf44c76
Compare
CuriousTommy
added a commit
to darlinghq/darling
that referenced
this pull request
May 17, 2025
darlinghq/darling-cocotron#40 | Add some CoreText stub definitions darlinghq/darling-cocotron#42 | Fix NSWindowTemplate logic not applying to both keyed and unkeyed decoding darlinghq/darling-cocotron#43 | fix(CoreText): missing kCTFontOpenTypeFeature Key and Value darlinghq/darling-cocotron#44 | several missing symbols
Author
|
@CuriousTommy do you plan on closing #13 ? I think it's been resolved now. |
Closed
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
taking ownership of #13 , since it's been untouched for a very long time, and I have the resources to get the actual values via darlinghq/darling#1588 (comment).
I've already rebased their branch on master, removed duplicates (symbols already in the master branch) and squashed, but I still need to get the actual values for
NSFontFeatureSelectorIdentifierKeyshould beCTFeatureSelectorIdentifierNSFontFeatureTypeIdentifierKeyshould beCTFeatureTypeIdentifierkCGFontNameKeyCopyrightdoesn't seem to exist?kCGFontNameKeyFontFamilydoesn't seem to exist?kCGFontNameKeyFontSubfamilydoesn't seem to exist?kCGFontNameKeyFullNamedoesn't seem to exist?kCGFontNameKeyPostScriptNamedoesn't seem to exist?kCGFontNameKeyPreferredFamilydoesn't seem to exist?kCGFontNameKeyPreferredSubfamilydoesn't seem to exist?kCGFontNameKeyVersiondoesn't seem to exist?I also need to
but I don't know which apps to test this on.
missing symbols required by MorxTester
fixes darlinghq/darling#801
missing symbols required by fontworker,fontmover,FontRegistryUIAgent
no longer does anything about darlinghq/darling#805
more missing symbols required by MorxTester
more symbols required by fontworker