Merged
Conversation
Author
|
@CuriousTommy I have updated all the NSKeyValueBinding constants to use the typedefs and this Foundation change is now required. I also sorted and grouped the constants like in the Apple header file. |
CuriousTommy
requested changes
Sep 22, 2025
CuriousTommy
left a comment
CuriousTommy
left a comment
There was a problem hiding this comment.
Please be careful with how you use Apple's SDK as a reference. There is NEVER a good reason to copy comments from Apple's SDK.
Other then that, I have some minor code changes I need you to do.
sirnacnud
force-pushed
the
xcode-3.0
branch
from
481dd3c to
e6dd2c3
Compare
Author
|
@CuriousTommy Thanks for the feedback. I made two new commits for fixing the line formatting and updating the constant values. The other fixes I squashed into the previous commits. |
CuriousTommy
requested changes
Sep 25, 2025
CuriousTommy
added a commit
to darlinghq/darling
that referenced
this pull request
Sep 27, 2025
darlinghq/darling-cocotron#47 | Add stubs for Xcode 3.0 darlinghq/darling-cocotron#48 | Add symbols for BibDesk darlinghq/darling-corecrypto#12 | Export _cccurve25519_make_key_pair symbol darlinghq/darling-foundation#20 | Add macros for NS_TYPED_ENUM darlinghq/darling-foundation#21 | Add symbols for BibDesk
CuriousTommy
added a commit
to darlinghq/darling
that referenced
this pull request
Sep 30, 2025
darlinghq/darling-cocotron#47 | Add stubs for Xcode 3.0 darlinghq/darling-cocotron#48 | Add symbols for BibDesk darlinghq/darling-corecrypto#12 | Export _cccurve25519_make_key_pair symbol darlinghq/darling-foundation#20 | Add macros for NS_TYPED_ENUM darlinghq/darling-foundation#21 | Add symbols for BibDesk
CuriousTommy
added a commit
to darlinghq/darling
that referenced
this pull request
Sep 30, 2025
darlinghq/darling-cocotron#47 | Add stubs for Xcode 3.0 darlinghq/darling-cocotron#48 | Add symbols for BibDesk darlinghq/darling-corecrypto#12 | Export _cccurve25519_make_key_pair symbol darlinghq/darling-foundation#20 | Add macros for NS_TYPED_ENUM darlinghq/darling-foundation#21 | Add symbols for BibDesk darlinghq/darling-foundation#22 | Fix NSSocketPortNameServer header reference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are stubs required by Xcode 3.0. See each commit title for a description of the stubs.