cmake: Make Python 2 bytecode pre-compilation optional#1356
Merged
facekapow merged 1 commit intodarlinghq:masterfrom Apr 26, 2023
Merged
cmake: Make Python 2 bytecode pre-compilation optional#1356facekapow merged 1 commit intodarlinghq:masterfrom
facekapow merged 1 commit intodarlinghq:masterfrom
Conversation
12 tasks
facekapow
approved these changes
Apr 23, 2023
Member
facekapow
left a comment
facekapow
left a comment
There was a problem hiding this comment.
LGTM
In my opinion, this seems like a good solution for now; you're right that it shouldn't cause any issues, just make it execute slower. I'll wait for input from one of the other maintainers, but I certainly prefer this over including the pyc files in the repos.
Member
|
How about rather than making this an off-by-default option (which nobody is going to enable), we detect whether Python 2 is present and auto-enable pyc in that case? |
Member
|
Ah, it's on by default. Fine then, though autodetection (i.e. without |
This affects performance while preserving compatibility. Ref: darlinghq#1074
zhaofengli
force-pushed
the
pyc-optional
branch
from
6d04592 to
1aa6026
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This affects performance while preserving compatibility.
We can't remove it altogether just yet since there are still things depending on it, like older versions of Xcode. A new prefix has
xattrandxcode-select --installdepending on Python 2.Ref: #1074