Disable dependency file generation#1554
Merged
CuriousTommy merged 2 commits intodarlinghq:masterfrom Nov 13, 2024
Merged
Conversation
This is because ld64 in cctools does not support --dependency-file flag
Contributor
|
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build fails on cmake v3.31.0, as it starts defaulting
CMAKE_${LANG}_LINKER_DEPFILE_SUPPORTEDtoTRUEby default. Having that set toTRUEwill make cmake add--dependency-fileto the linker flags, however ld64 in cctools does not support this flag, causing the build to break.This PR disables dependency file generation to match the previous behavior.