feat: add some LS Handler Stubs#1582
Merged
CuriousTommy merged 1 commit intodarlinghq:masterfrom May 11, 2025
Merged
Conversation
Lazerbeak12345
commented
May 6, 2025
Lazerbeak12345
commented
May 6, 2025
src/frameworks/CoreServices/include/LaunchServices/LSInfoDeprecated.h
Outdated
Show resolved
Hide resolved
Lazerbeak12345
commented
May 6, 2025
Contributor
Author
|
Contributor
Author
|
|
Lazerbeak12345
changed the title
Lazerbeak12345
commented
May 6, 2025
src/frameworks/CoreServices/include/LaunchServices/LSInfoDeprecated.h
Outdated
Show resolved
Hide resolved
CuriousTommy
requested changes
May 10, 2025
Contributor
CuriousTommy
left a comment
CuriousTommy
left a comment
There was a problem hiding this comment.
Code looks good. Haven't tested it on my machine yet. The only request I have is to get rid of the comments.
CuriousTommy
approved these changes
May 10, 2025
Contributor
CuriousTommy
left a comment
CuriousTommy
left a comment
There was a problem hiding this comment.
Looks good to me! Just merge your commits into one and I'll merge it.
On a side note, you don't need to co-author me for minor formatting changes (removing comments, formatting source code, etc.)
feat: add a few more style: remove both incorrect and unwanted comments
Lazerbeak12345
force-pushed
the
add-lscopyallhandlersforurlscheme-stub
branch
from
d8d74fc to
ff34a9b
Compare
Contributor
|
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1578