Skip to content

Comments

feat: add a few missing AppleEvent stubs#1583

Merged
CuriousTommy merged 1 commit intodarlinghq:masterfrom
Lazerbeak12345:add-missing-coreservices-definitions
May 11, 2025
Merged

feat: add a few missing AppleEvent stubs#1583
CuriousTommy merged 1 commit intodarlinghq:masterfrom
Lazerbeak12345:add-missing-coreservices-definitions

Conversation

@Lazerbeak12345
Copy link
Contributor

closes #1577

Copy link
Contributor

@CuriousTommy CuriousTommy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@Lazerbeak12345 Lazerbeak12345 marked this pull request as draft May 10, 2025 14:48
@Lazerbeak12345
Copy link
Contributor Author

marked as draft so I can test the changes

@Lazerbeak12345
Copy link
Contributor Author

changes compiled, the application in question hit the next missing symbol (outside of AppleEvent and CoreServices)

@Lazerbeak12345 Lazerbeak12345 marked this pull request as ready for review May 10, 2025 15:40
Copy link
Contributor

@CuriousTommy CuriousTommy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Same as your other PR, merge your commits into one commit and I'll merge your changes.

@Lazerbeak12345 Lazerbeak12345 marked this pull request as draft May 11, 2025 01:57
style: touching leading pointer

style: move AEInstallEventHandler to AppleEvents from AE
@Lazerbeak12345 Lazerbeak12345 force-pushed the add-missing-coreservices-definitions branch from 877a452 to 29ef151 Compare May 11, 2025 02:06
@Lazerbeak12345 Lazerbeak12345 marked this pull request as ready for review May 11, 2025 04:01
@CuriousTommy CuriousTommy merged commit fd4ba40 into darlinghq:master May 11, 2025
2 checks passed
@CuriousTommy
Copy link
Contributor

Thank you for your contribution!

@Lazerbeak12345 Lazerbeak12345 deleted the add-missing-coreservices-definitions branch May 19, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing _AEInstallEventHandler symbol

2 participants