fix: stop all running darling servers on uninstall#1584
Merged
CuriousTommy merged 1 commit intodarlinghq:masterfrom May 11, 2025
Merged
fix: stop all running darling servers on uninstall#1584CuriousTommy merged 1 commit intodarlinghq:masterfrom
CuriousTommy merged 1 commit intodarlinghq:masterfrom
Conversation
CuriousTommy
requested changes
May 9, 2025
Contributor
CuriousTommy
left a comment
There was a problem hiding this comment.
The script is broken
Seeing if Darling is currently running
error: list of process IDs must follow -p
Usage:
ps [options]
Try 'ps --help <simple|list|output|threads|misc|all>'
or 'ps --help <s|l|o|t|m|a>'
for additional help text.
For more details see ps(1).
Darling currently running for , shutting it down...
sudo: unknown user darling
sudo: error initializing audit plugin sudoers_audit
Contributor
Author
|
Tested much more extensively this time. I noticed that sometimes |
Contributor
Author
|
The other thing: this script makes the assumption that a user can run
|
CuriousTommy
approved these changes
May 10, 2025
Contributor
CuriousTommy
left a comment
There was a problem hiding this comment.
LGTM. Once you combine your commits into one, I'll merge your changes.
fix: quotes are needed with test UNIX util fix: privilage checking
58bba75 to
9201b43
Compare
Contributor
|
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1579