Skip to content

Comments

add missing IBCarbonRuntime.h, associated stubs and modifications to HIToolbox#1589

Merged
CuriousTommy merged 3 commits intodarlinghq:masterfrom
Lazerbeak12345:add-missing-ibcarbonruntime-header
May 19, 2025
Merged

add missing IBCarbonRuntime.h, associated stubs and modifications to HIToolbox#1589
CuriousTommy merged 3 commits intodarlinghq:masterfrom
Lazerbeak12345:add-missing-ibcarbonruntime-header

Conversation

@Lazerbeak12345
Copy link
Contributor

@Lazerbeak12345 Lazerbeak12345 commented May 17, 2025

@Lazerbeak12345 Lazerbeak12345 marked this pull request as ready for review May 17, 2025 15:58
@Lazerbeak12345 Lazerbeak12345 changed the title add missing IBCarbonRuntime.h add missing IBCarbonRuntime.h and associated stubs May 17, 2025
@Lazerbeak12345 Lazerbeak12345 force-pushed the add-missing-ibcarbonruntime-header branch from c6f713d to 0627a9c Compare May 17, 2025 16:17
@Lazerbeak12345
Copy link
Contributor Author

Lazerbeak12345 commented May 17, 2025

Oh, I should also point out, according to the sources I have, on macOS, this header is not available on 64 bit intel, but is available on 32 bit intel, and older (I assume all PowerPC bittages as well, since this API predates much of the Core Foundation and OpenStep APIs, IIRC)

In this PR, I've figured since the rest of the HIToolbox APIs are compiled to be available in darling, even in 64 bit intel, it should be fine to replicate that behavior for this API as well.

@CuriousTommy
Copy link
Contributor

CuriousTommy commented May 17, 2025

In this PR, I've figured since the rest of the HIToolbox APIs are compiled to be available in darling, even in 64 bit intel, it should be fine to replicate that behavior for this API as well.

I think that is okay. If that becomes a problem, we can always fix the code (or build script) in the future.

@Lazerbeak12345 Lazerbeak12345 marked this pull request as draft May 17, 2025 21:07
@Lazerbeak12345 Lazerbeak12345 force-pushed the add-missing-ibcarbonruntime-header branch from 0627a9c to 431b864 Compare May 17, 2025 22:30
@Lazerbeak12345 Lazerbeak12345 marked this pull request as ready for review May 18, 2025 23:36
@Lazerbeak12345 Lazerbeak12345 changed the title add missing IBCarbonRuntime.h and associated stubs add missing IBCarbonRuntime.h, associated stubs and modifications to HIToolbox May 18, 2025
Copy link
Contributor

@CuriousTommy CuriousTommy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@CuriousTommy CuriousTommy merged commit 0e09aec into darlinghq:master May 19, 2025
2 checks passed
@Lazerbeak12345 Lazerbeak12345 deleted the add-missing-ibcarbonruntime-header branch May 19, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing _CreateNibReference symbol

2 participants