Skip to content

Comments

Add symbols for BibDesk#1612

Merged
CuriousTommy merged 1 commit intodarlinghq:masterfrom
jlucfarias:add-symbols-bibdesk
Sep 30, 2025
Merged

Add symbols for BibDesk#1612
CuriousTommy merged 1 commit intodarlinghq:masterfrom
jlucfarias:add-symbols-bibdesk

Conversation

@jlucfarias
Copy link
Contributor

Last set of patches to improve BibDesk execution (complement of darling-foundation#21 and darling-cocotron#48).
With all merged, it fixes #572

Copy link
Contributor

@CuriousTommy CuriousTommy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks good; however, I do have one concern with src/frameworks/PDFKit/include/PDFKit/PDFKitExport.h‎

@jlucfarias
Copy link
Contributor Author

@CuriousTommy fixed

Copy link
Contributor

@CuriousTommy CuriousTommy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CuriousTommy CuriousTommy merged commit 4ef31fd into darlinghq:master Sep 30, 2025
2 checks passed
@jlucfarias jlucfarias deleted the add-symbols-bibdesk branch September 30, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[GUI] FileView missing

2 participants