Improve yaml serialization quoting#4217
Draft
sigurdm wants to merge 1 commit intodart-lang:masterfrom
Draft
Conversation
lrhn
reviewed
Feb 13, 2025
Member
lrhn
left a comment
lrhn
left a comment
There was a problem hiding this comment.
(Drive-by-comments. I saw a regexp, so I had to say something.)
| 'null', 'Null', 'NULL', | ||
| ].contains(s)) return true; | ||
| // Numbers must be quoted | ||
| if (RegExp(r'^[-+]?[0-9]*\.?[0-9]*(e[0-9]+)?$').hasMatch(s)) return true; |
Member
There was a problem hiding this comment.
This is a potentially dangerous RegExp because of the \d*\.?\d* sequence. It's probably not exponential, but it can be quadratic in the length to reject something like 00000000000000000000000....0000000x
Consider changing to \d*(\.\d*)? (And be aware that it still matches . alone.)
| // Numbers must be quoted | ||
| if (RegExp(r'^[-+]?[0-9]*\.?[0-9]*(e[0-9]+)?$').hasMatch(s)) return true; | ||
| // Hex numbers must be quoted | ||
| if (RegExp(r'^0x[0-9]+$').hasMatch(s)) return true; |
| /// which means some strings may be unnecessarily quoted. | ||
| bool _needsYamlQuotes(String s) { | ||
| // These must be quoted | ||
| if ([ |
Member
There was a problem hiding this comment.
List can be const. (Small save, but save, over creating a new list on every invocation.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4214
We should only merge this if we want accept disturbing almost all pubspec.locks.
Maybe we can bundle it with another update to pubspec.lock structure.
We can also make a smalller update that just fixes bugs.