Skip to content

Conversation

@youngsofun
Copy link
Member

@youngsofun youngsofun commented Nov 11, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

the origin impl #18936 not work for query level settings.

settings (timezone='UTC') select 1

after this pr, since the settings is not None until after binding. for timezone info, client only need to use it after data arrives.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Nov 11, 2025
@youngsofun youngsofun merged commit e9cc22c into databendlabs:main Nov 12, 2025
93 of 96 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix this PR patches a bug in codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants