fix(query): escape LIKE ESCAPE literals in display#19596
Merged
sundy-li merged 1 commit intodatabendlabs:mainfrom Mar 24, 2026
Merged
fix(query): escape LIKE ESCAPE literals in display#19596sundy-li merged 1 commit intodatabendlabs:mainfrom
sundy-li merged 1 commit intodatabendlabs:mainfrom
Conversation
KKould
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
This fixes the
LIKE ... ESCAPEformatter roundtrip bug for escape literals that contain single quotes. Statements such asSELECT 'a' LIKE 'a' ESCAPE '''';now serialize back to valid SQL, so the parser's debug reparse assertion no longer panics.Changes
Expr::LikeSubquery,Expr::LikeAnyWithEscape, andExpr::LikeWithEscapeescape literals with the sharedQuotedStringSQL string formatterLIKE,LIKE ANY (...), andLIKE ANY (SELECT ...)withESCAPE ''''Tests
Validation:
cargo test -p databend-common-astcargo clippy -p databend-common-ast --tests -- -D warningsType of change
Fixes #19563
This change is