fix(sql): treat X'...' as binary literal#19608
Open
sundy-li wants to merge 1 commit intodatabendlabs:mainfrom
Open
fix(sql): treat X'...' as binary literal#19608sundy-li wants to merge 1 commit intodatabendlabs:mainfrom
sundy-li wants to merge 1 commit intodatabendlabs:mainfrom
Conversation
Contributor
|
At least one type of change must be checked in the PR description. |
Contributor
🤖 CI Job Analysis
📊 Summary
❌ NO RETRY NEEDEDAll failures appear to be code/test issues requiring manual fixes. 🔍 Job Details
🤖 AboutAutomated analysis using job annotations to distinguish infrastructure issues (auto-retried) from code/test issues (manual fixes needed). |
Member
Author
|
Blocking issue: The new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
X'...'as a binary literal instead of routing it through the unsigned hex integer path0x...literals as numeric literalsTests
cargo test -p databend-common-astcargo test -p databend-common-functions --test it type_check::test_pg_hex_literal_type_check -- --nocapturecargo test -p databend-common-sql --test it --no-runcargo clippy -p databend-common-ast --tests -- -D warningscargo run -p databend-sqllogictests -- --run_file binary_format.test --handlers mysql(requires a running Databend server on127.0.0.1:3307; connection was refused in this environment)Fixes #19600
This change is