This repository was archived by the owner on Mar 3, 2026. It is now read-only.
Merged
Conversation
cla-bot
bot
added
the
cla-signed
bjchambers
changed the title
This is pretty ugly -- it has to do create a lot of fake locations and create enums (like `ExprOp`) just to call into the existing AST -> DFG compilation. We should definitely clean this up if we continue down the path of using builders.
bjchambers
force-pushed
the
ben/query-builder
branch
from
bc522c4 to
669dcfd
Compare
jordanrfrazier
approved these changes
Jul 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is pretty ugly -- it has to do create a lot of fake locations and create enums (like
ExprOp) just to call into the existing AST -> DFG compilation. We should definitely clean this up if we continue down the path of using builders.