This repository was archived by the owner on Mar 3, 2026. It is now read-only.
feat: Prepare data in rust#568
Merged
Merged
Conversation
This breaks some of the Rust code into a new `sparrow-session` crate providing a place for implementing things that aren't specific to the Python FFI. This also introdoces some pieces for error conversions, with the hope that we can grow to a point where we log errors on the rust side but surface relevant details to the Python side.
cla-bot
Bot
added
the
cla-signed
kevinjnguyen
approved these changes
Jul 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This breaks some of the Rust code into a new
sparrow-sessioncrate providing a place for implementing things that aren't specific to the Python FFI.This also introdoces some pieces for error conversions, with the hope that we can grow to a point where we log errors on the rust side but surface relevant details to the Python side.