This repository was archived by the owner on Mar 3, 2026. It is now read-only.
Merged
Conversation
This removes the ability to inspect the prepared data from the Python FFI. Instead, the Python FFI now has an `execute` method allowing you to inspect the results of an expression, including the bare table. This changes the execute methods a bit to have a simpler API to interface with. This relies on pushing "in-memory" data into the `DataContext`, which is very brittle and hacky. For example, it currently only supports adding data once, and requires that the schemas line up.
cla-bot
bot
added
the
cla-signed
bjchambers
commented
Jul 31, 2023
bjchambers
force-pushed
the
sparrow-py-execute
branch
from
cc1c185 to
ef87ad4
Compare
Collaborator
|
Approving to unblock since much will likely change anyway, will take a closer look in a couple hours |
jordanrfrazier
approved these changes
Aug 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the ability to inspect the prepared data from the Python FFI. Instead, the Python FFI now has an
executemethod allowing you to inspect the results of an expression, including the bare table.This changes the execute methods a bit to have a simpler API to interface with.
This relies on pushing "in-memory" data into the
DataContext, which is very brittle and hacky. For example, it currently only supports adding data once, and requires that the schemas line up.