This repository was archived by the owner on Mar 3, 2026. It is now read-only.
feat: Configurable retention on PyDict sources#744
Merged
bjchambers merged 6 commits intomainfrom Sep 8, 2023
Merged
Conversation
This renames the `PyList` source to `PyDict`. This allows the in-memory retention to be disabled for any source, but exposes this for the `PyDict` source, which is often used with materializations.
bjchambers
commented
Sep 7, 2023
bjchambers
commented
Sep 7, 2023
bjchambers
commented
Sep 7, 2023
bjchambers
commented
Sep 7, 2023
kerinin
approved these changes
Sep 7, 2023
Collaborator
|
I get an error when I run the script: |
Collaborator
Author
|
Hmm, yeah. Empty batches posed a problem. I think that should be fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This renames the
PyListsource toPyDict.This allows the in-memory retention to be disabled for any source, but exposes this for the
PyDictsource, which is often used with materializations.