Conversation
ErickRamirezDS
approved these changes
Jan 30, 2025
ErickRamirezDS
left a comment
ErickRamirezDS
left a comment
There was a problem hiding this comment.
Added a suggestion but looks good to me otherwise. 👍
OpsCenter_6.8_Release_Notes.md
Outdated
|
|
||
| ## Backup Service | ||
| * Added support for picking individual tables when creating a backup. (OPSC-17084) | ||
| * Updated aws sdk version. Aws cli will now be used for bucket validation if `use_s3_cli` is true. This resolves issues when using some generic S3 providers such as Cloudian. (OPSC-17639) |
There was a problem hiding this comment.
A friendly suggestion -- minor nit with capitalisation of proper nouns for consistency. For example, "Azure SDK" was previously referenced.
Suggested change
| * Updated aws sdk version. Aws cli will now be used for bucket validation if `use_s3_cli` is true. This resolves issues when using some generic S3 providers such as Cloudian. (OPSC-17639) | |
| * Updated AWS SDK version. AWS CLI will now be used for bucket validation if `use_s3_cli` is true. This resolves issues when using some generic S3 providers such as Cloudian. (OPSC-17639) |
Contributor
There was a problem hiding this comment.
@ErickRamirezDS's comments are good. I've added some additional suggestions below from the docs perspective, and included the AWS SDK version number from the pull request. Feel free to make changes as needed.
rh-datastax
reviewed
Jan 30, 2025
rh-datastax
reviewed
Jan 30, 2025
rh-datastax
approved these changes
Jan 30, 2025
Contributor
rh-datastax
left a comment
rh-datastax
left a comment
There was a problem hiding this comment.
Hi @orion104 - I've added some suggestions from the docs side. Take a look and let me know what you think. Otherwise, LGTM!
Thanks, Richard
Co-authored-by: Richard Hendricks <richard.hendricks@datastax.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes Automation
If you name your pull-request as "Product x.y.z Release ...", after merging the
PR, a GitHub Action will automatically create a product version tag "product-x.y.z".
Supported product names are:
Version supports 3 sets or 4 sets of digits.