Open
Conversation
Contributor
scotwells
reviewed
Sep 18, 2025
config/components/prometheus-monitoring/servicemonitor-etcd.yaml
Outdated
Show resolved
Hide resolved
config/overlays/test-infra/components/auth/auth-tokens-secret.yaml
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a comprehensive performance testing suite for Milo, including new automation tasks, Kubernetes job templates, RBAC resources, and documentation. It also increases memory limits for Milo and Etcd components and adds a Prometheus ServiceMonitor for Etcd metrics. The changes enable end-to-end performance scenario execution, result collection, and resource cleanup, supporting scalable and reproducible benchmarking.
Performance Testing Suite
perf:runandperf:cleanuptasks inTaskfile.yamlto automate running Milo performance scenarios and cleaning up test resources, including downloading results and handling environment overrides.perf-runner-job.yaml) and cleaning up (perf-cleanup-job.yaml) performance tests, with proper environment variable injection and kubeconfig mounting.perf-runner-rbac.yaml) to allow the performance runner jobs to manage ConfigMaps for result storage.README.mddescribing the performance runner workflow, configuration options, outputs, and usage examples.Observability Improvements
ServiceMonitorfor Etcd inservicemonitor-etcd.yamlto enable metrics scraping in themilo-systemnamespace.Resource Tuning
deployment.yaml) and Etcd (helmrelease.yaml) from 512Mi to 2G to better support performance testing at scale.Test Infrastructure
auth-tokens-secret.yamlfrom1001toadmin.