x86: Avoid using DX register as divisor#175
Open
shattered wants to merge 1 commit intodavidgiven:masterfrom
Open
x86: Avoid using DX register as divisor#175shattered wants to merge 1 commit intodavidgiven:masterfrom
shattered wants to merge 1 commit intodavidgiven:masterfrom
Conversation
Contributor
Author
|
Is the C backend easily fixable? I can remove the test if not. |
Owner
|
The C backend should absolutely support signed division. The signed-ness is a property of the operator, not the type; the code generated looks like:
Do you know what the operations are producing with the C backend? I wonder if the Cowgol signed-division rules are different to the C signed-division rules... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C backend doesn't seem to support signed integers and fails the new test -- no idea how to fix that