-
Notifications
You must be signed in to change notification settings - Fork 10
GP v0.6.7 #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update `ServiceInfo` (all fields are fixed-length now).
|
Thanks for these.
EDIT: Removed second question, figured it out. So far all stf, safrole traces and fallback traces pass for me. I get a different gas used amount in reports-l0/00000002 but other fields are matching. |
to what json you refer to?
well, the second service code preimage fails to load but perhaps we need to update the accumulate slot anyway? So maybe you were right. I need to check the gp |
The service accounts. For example stf/accumulate/tiny/accumulate_ready_queued_reports-1.json:
Old attributes are named like "min_item_gas", "min_memo_gas". New ones use a dash instead: "deposit-offset", "creation-slot". Just mentioning for consistency in naming. |
Ok Regarding the accum slot, you were right. We need to update both services last slot. I'll fix it |
|
For traces, we are passing fallback + safrole but are dying early on reports-l0/00000002 and reports-l1/00000002 -- can you paste the pvm traces for one or both? |
|
@sourabhniyogi I’ve provided the light variant of the traces related to the reports:
Since I regenerated all the traces, some parts of the traces may have changed. |
|
A trace for any of these would be really useful as I'm still running into gas discrepancies and I'm assuming its probably the same issue causing my problem in each. preimages_light/00000003 - Javajam: 14446. Polkajam: 14658 Everything else matches in the post states except gas. Also just realized they all differ from the same amount somehow: 212. |
|
After fixing up the fetch protocol specs to be 0.7.0 (no idea why you would need to do this?), we got to the same observation as @jaymansfield .. that we have 212 less gas across the majority of accumulate state transitions for both storage+preimage, light or not. Our summary is here which shows the 212 mismatch. Do you have a theory of what is going on at the last 212? We will check what's going on with some statistics count mismatches here and what we may be missing for the > 212 mismatches. Note that we had to loosen up our memory checks to get to this state and are ignoring it because we assume something will replace SBRK soonish. |
|
Same issue here - FastRoll consumes 212 fewer gas units compared to the test vectors, across all test vectors that invoke accumulation. All other fields match. |
|
@jaymansfield @sourabhniyogi @0xjunha pvm traces for: |
@jaymansfield is the service 0 balance as returned by the This is the object that is returned encoded from the |
Service is matching already. Can you check to see which registers you are using for the info host call here: I noticed if I set it to W9 & W10 the trace passes. |
Looks like you found something interesting. Please use w9 and w10. With this change all the traces are passing? |
Yes all tests pass now for JavaJAM 😀 |
@jaymansfield thank you for reporting this So perhaps that was the issue for you as well? @sourabhniyogi @0xjunha |
Yes, with w9 & w10 for INFO hostcall |
|
FYI : gavofyork/graypaper#480 |
We have passed storage-light with the info w9/10 "fix" and are working through preimages-light now. Because @jaymansfield and @0xjunha have support, all issues are almost certainly on our side, so we would like 0.7.0 vectors in the Will confirm when we're 100% done |
|
PyJAMaz passes all STF en traces tests, with help of comments above 😄 |
|
JamDuna also passes all v0.6.7 STF trace tests. { |
|
Boka passes all as well |
|
Jamzilla passes as well |
|
@jamixir passing all 0.6.7 traces |
|
@davxy Could your share PVM traces for the following test cases?
All |

✅ Please report your success/issues here
Protocol version 0.6.7$^*$
CHANGELOG
(*) WARNING: DEVIATIONS
Changes from version 0.7.0 that have already been incorporated
assignhostcall gavofyork/graypaper#433** Unreleased**