fix: address Copilot review comments on PR #197#198
Merged
Conversation
- ReaderDefaults: clarify XML doc to distinguish file-path (bytes) from stream/string (characters) size limit semantics - XddDeviceProfileParser: fix indentation so methods are properly indented inside the class body Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates minor cosmetic issues in the parsing layer to align with prior review feedback, without changing runtime behavior.
Changes:
- Clarifies
ReaderDefaults.DefaultMaxInputSizeXML documentation to distinguish byte-based vs decoded-character limits. - Fixes indentation in
XddDeviceProfileParserso methods are correctly nested within the class body.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/EdsDcfNet/Parsers/XddDeviceProfileParser.cs |
Whitespace/indentation cleanup to keep methods properly scoped/indented within the class. |
src/EdsDcfNet/Parsers/ReaderDefaults.cs |
Doc comment wording updated to clarify how the default max input size is interpreted for different input sources. |
You can also share your feedback on Copilot code review. Take the survey.
dborgards
pushed a commit
that referenced
this pull request
Mar 7, 2026
## [1.8.0-beta.4](v1.8.0-beta.3...v1.8.0-beta.4) (2026-03-07) ### 🐛 Bug Fixes * address Copilot review comments on PR [#197](#197) ([#198](#198)) ([cb3a371](cb3a371)) ### 📚 Documentation * clarify UTF-8 no-BOM writer policy and interoperability ([#187](#187)) ([9ece6bb](9ece6bb)), closes [#130](#130)
dborgards
pushed a commit
that referenced
this pull request
Mar 7, 2026
## [1.8.0](v1.7.1...v1.8.0) (2026-03-07) ### ✨ Features * Add model validation for CANopen constraints ([#173](#173)) ([6d24f89](6d24f89)), closes [#118](#118) * add stream-based read/write APIs ([#174](#174)) ([9b33d79](9b33d79)), closes [#120](#120) [#120](#120) [#120](#120) [#120](#120) [#120](#120) [#120](#120) [#120](#120) [#120](#120) [#120](#120) [#120](#120) [#120](#120) [#120](#120) [#120](#120) [#120](#120) [#180](#180) * improve EdsToDcf time source testability ([#185](#185)) ([4d22237](4d22237)), closes [#115](#115) * make parser input size limits configurable ([#170](#170)) ([75f0978](75f0978)) ### 🐛 Bug Fixes * address Copilot review comments on PR [#197](#197) ([#198](#198)) ([cb3a371](cb3a371)) * improve invalid numeric literal error context ([#158](#158)) ([c57646d](c57646d)) * reject NodeId 0 in DCF model validation ([#182](#182)) ([11c1a7c](11c1a7c)) * remove accidental .claude worktree gitlink ([c456703](c456703)) ### 📚 Documentation * clarify UTF-8 no-BOM writer policy and interoperability ([#187](#187)) ([9ece6bb](9ece6bb)), closes [#130](#130)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses open Copilot review comments from PR #197.
Test plan
Note
Low Risk
Documentation and whitespace-only changes; no functional code paths or data handling behavior are modified.
Overview
Updates the XML documentation for
ReaderDefaults.DefaultMaxInputSizeto explicitly distinguish byte-based limits for file-path inputs from decoded-character limits for stream/string inputs.Fixes formatting in
XddDeviceProfileParserby reindentingParseFileInfoandParseDeviceIdentityso they’re properly nested within the class body (no logic changes).Written by Cursor Bugbot for commit 57eb670. This will update automatically on new commits. Configure here.