Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12361 +/- ##
=======================================
Coverage 91.36% 91.36%
=======================================
Files 203 203
Lines 25092 25092
=======================================
Hits 22925 22925
Misses 2167 2167
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
QMalcolm
added a commit
that referenced
this pull request
Jan 21, 2026
This reverts commit 7634345. We're doing this because that fix wasn't actually what fixed our problem, and it seems to be causing some edge case with our structured logging testing environment. That itself worries me that this has created some edge case behavior change that we are unaware of.
5 tasks
QMalcolm
added a commit
that referenced
this pull request
Jan 22, 2026
* Revert "Add typing for bool flag values (#12361)" This reverts commit 7634345. We're doing this because that fix wasn't actually what fixed our problem, and it seems to be causing some edge case with our structured logging testing environment. That itself worries me that this has created some edge case behavior change that we are unaware of. * Add testing of click flag resolution * Bump minimum `click` version to 8.3.0
abhishek09827
pushed a commit
to abhishek09827/dbt-core
that referenced
this pull request
Feb 19, 2026
* Add type=click.BOOL for all flag options * changelog
abhishek09827
pushed a commit
to abhishek09827/dbt-core
that referenced
this pull request
Feb 19, 2026
…labs#12378) * Revert "Add typing for bool flag values (dbt-labs#12361)" This reverts commit 7634345. We're doing this because that fix wasn't actually what fixed our problem, and it seems to be causing some edge case with our structured logging testing environment. That itself worries me that this has created some edge case behavior change that we are unaware of. * Add testing of click flag resolution * Bump minimum `click` version to 8.3.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like with the version bump of
click, flags are now rendering incorrectly without thetype=click.BOOLbeing set. Ie.,and none of the click falsey values are being respected (ie.,
0,false,off).Problem
Solution
Checklist