Fix issue with node selection at ring boundary#36
Merged
debasishg merged 1 commit intodebasishg:masterfrom Sep 8, 2012
patriknw:wip-consistent-hash-improvements
Merged
Fix issue with node selection at ring boundary#36debasishg merged 1 commit intodebasishg:masterfrom patriknw:wip-consistent-hash-improvements
debasishg merged 1 commit intodebasishg:masterfrom
patriknw:wip-consistent-hash-improvements
Conversation
* The small problem was that it picked node counter clockwise in the ring for all, except for crc < firstKey, where it picked firstKey instead of lastKey * Changed to clockwise selection and correct selection at the boundary, i.e. crc > lastKey => firstKey and crc < firstKey => firstKey * Changed to TreeMap instead of the 2 separate TreeSet and Map collections
ghost
assigned
debasishg
added a commit
that referenced
this pull request
Sep 8, 2012
Fix issue with node selection at ring boundary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in the ring for all, except for crc < firstKey, where it picked firstKey
instead of lastKey
at the boundary, i.e. crc > lastKey => firstKey
and crc < firstKey => firstKey
collections