Skip to content

added asLong and changed most of the commands that return Option[Int] to be Option[Long]#41

Merged
debasishg merged 1 commit intodebasishg:masterfrom
AhmedSoliman:master
Sep 19, 2012
Merged

added asLong and changed most of the commands that return Option[Int] to be Option[Long]#41
debasishg merged 1 commit intodebasishg:masterfrom
AhmedSoliman:master

Conversation

@AhmedSoliman
Copy link

an integer in redis is a signed 64-bit, this is Long in Scala.

@debasishg
Copy link
Owner

Thinking if this will create any issues with existing users .. what do you think ?

@AhmedSoliman
Copy link
Author

yeah, this will break the API for most of the users. but it's very important, an INCR command will fail if it exceeded Int.MaxValue while on the database it can hold up to Long.MaxValue

@ghost ghost assigned debasishg Sep 17, 2012
@debasishg
Copy link
Owner

Thanks for the patch. Will merge over the weekend.

debasishg added a commit that referenced this pull request Sep 19, 2012
added asLong and changed most of the commands that return Option[Int] to be Option[Long]
@debasishg debasishg merged commit 64c9c6c into debasishg:master Sep 19, 2012
@AhmedSoliman
Copy link
Author

when are you supposed to publish a new version on your mvn repo so I can directly use it?

@debasishg
Copy link
Owner

I pushed it to sonatype just now .. It may take some time to sync with Maven Central .. Thanks

@AhmedSoliman
Copy link
Author

is this the 2.7 version? seems that you pushed that for scala 2.9.2 only, I need it for 2.9.1

@debasishg
Copy link
Owner

oops .. didn't know u need for 2.9.1 .. let me do a build and push .. pls give me a day ..

@debasishg
Copy link
Owner

ok .. got some time and pushed to sonatype .. maven central sync will happen some time ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants