Adds optional secret parameter to RedisClientPool initializer#59
Closed
efuquen wants to merge 1 commit intodebasishg:masterfrom
Closed
Adds optional secret parameter to RedisClientPool initializer#59efuquen wants to merge 1 commit intodebasishg:masterfrom
efuquen wants to merge 1 commit intodebasishg:masterfrom
Conversation
…client has been initialized. prevents need to do this every time you grab a redis client from the pool, even if its a cached instance
Author
|
curious if there is any comment on this, does this way of implementing the auth make sense or are there any objections? |
Owner
|
Thanks for the pull request. I will have a detailed look over this weekend. Apologies for not getting back earlier. |
Owner
|
merged manually .. Thanks for the pull request |
Seyun
pushed a commit
to Seyun/scala-redis
that referenced
this pull request
Nov 24, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With redis pool there is no way to pass in the secret to the pool, so any redis server requiring authorization would force the auth call to occur everytime someone uses withClient. The RedisPool implementation can easily just call auth only once, everytime it creates the redis client, if it had access to the secret passed in on pool initialization. this pull requests adds that optional parameter.