feature(create-typink): reimplement create-typink#257
Merged
Conversation
# Conflicts: # packages/create-typink/src/createProject.ts
# Conflicts: # packages/create-typink/templates/legacy-subconnectv2-vite/package.json # packages/create-typink/templates/v6-subconnectv2-vite/package.json # yarn.lock
There was a problem hiding this comment.
Pull Request Overview
This PR reimplements the create-typink tool to streamline development by changing from a customizable wizard approach to a simple template-based system. The tool now requires only two arguments: projectName and templateName, using a naming convention of {inkVersion}-{walletConnector}-{ui}.
- Simplifies the create-typink interface from a complex wizard to two required arguments
- Introduces standardized template naming convention for easier template selection
- Adds comprehensive template files for both Vite and Next.js variants with Typink integration
Reviewed Changes
Copilot reviewed 200 out of 599 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| packages/create-typink/templates/legacy-typink-vite/* | Complete Vite-based template with Chakra UI, TypeScript, and Typink integration |
| packages/create-typink/templates/legacy-typink-nextjs/* | Complete Next.js template with ShadCN UI, TypeScript, and Typink integration |
| packages/create-typink/templates/legacy-talisman-vite/* | Vite template variant with Talisman wallet integration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/create-typink/templates/legacy-typink-vite/src/components/shared/WalletSelection.tsx
Outdated
Show resolved
Hide resolved
packages/create-typink/templates/legacy-typink-vite/src/contracts/deployments.ts
Show resolved
Hide resolved
packages/create-typink/templates/legacy-typink-vite/src/main.tsx
Outdated
Show resolved
Hide resolved
...ges/create-typink/templates/legacy-typink-nextjs/src/components/dialog/account-selection.tsx
Show resolved
Hide resolved
packages/create-typink/templates/legacy-typink-nextjs/src/components/tx-toaster.tsx
Show resolved
Hide resolved
packages/create-typink/templates/legacy-talisman-vite/src/providers/WalletConnectorProvider.tsx
Show resolved
Hide resolved
Member
|
This PR is getting bigger, let's merge this for now, we'll continue to improve & optimize this further later in another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create-typinkworks. The current implementation makes it time-consuming to develop features or add new templates, so we decided to revise it.{inkVersion}-{walletConnector}-{ui}, where:inkVersion: legacy | v6walletConnector: typink | subconnectv2 | talismanui: vite | nextjs$ npm create typink -n my-typink-app -t legacy-typink-nextjs$ bun create typink -n my-typink-app -t v6-subconnectv2-vite