Create SessionService#TerminationNotification as best-effort attempt to notify on worker exit#1210
Merged
nbauernfeind merged 9 commits intodeephaven:mainfrom Sep 17, 2021
Conversation
rcaudy
reviewed
Sep 3, 2021
grpc-api/src/main/java/io/deephaven/grpc_api/console/ConsoleServiceGrpcImpl.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Sep 3, 2021
grpc-api/src/main/java/io/deephaven/grpc_api/console/ConsoleServiceGrpcImpl.java
Outdated
Show resolved
Hide resolved
nbauernfeind
force-pushed
the
fatal_err_interceptor
branch
from
63f76ec to
caeb348
Compare
nbauernfeind
changed the title
rcaudy
reviewed
Sep 3, 2021
Member
rcaudy
left a comment
rcaudy
left a comment
There was a problem hiding this comment.
I think two of my comments are probably nonsense, since you seem to be relying on a "two stage" effect in the case of fatal error.
grpc-api/src/main/java/io/deephaven/grpc_api/console/ConsoleServiceGrpcImpl.java
Show resolved
Hide resolved
grpc-api/src/main/java/io/deephaven/grpc_api/session/SessionService.java
Show resolved
Hide resolved
grpc-api/src/main/java/io/deephaven/grpc_api/session/SessionService.java
Outdated
Show resolved
Hide resolved
grpc-api/src/main/java/io/deephaven/grpc_api/session/SessionService.java
Show resolved
Hide resolved
proto/proto-backplane-grpc/src/main/proto/deephaven/proto/session.proto
Outdated
Show resolved
Hide resolved
grpc-api/src/main/java/io/deephaven/grpc_api/runner/DeephavenApiServer.java
Show resolved
Hide resolved
nbauernfeind
force-pushed
the
fatal_err_interceptor
branch
from
caeb348 to
616f0f4
Compare
rcaudy
previously approved these changes
Sep 3, 2021
niloc132
reviewed
Sep 4, 2021
grpc-api/src/main/java/io/deephaven/grpc_api/session/SessionService.java
Show resolved
Hide resolved
grpc-api/src/main/java/io/deephaven/grpc_api/session/SessionServiceGrpcImpl.java
Outdated
Show resolved
Hide resolved
grpc-api/src/main/java/io/deephaven/grpc_api/session/SessionServiceGrpcImpl.java
Outdated
Show resolved
Hide resolved
grpc-api/src/main/java/io/deephaven/grpc_api/session/SessionServiceGrpcImpl.java
Outdated
Show resolved
Hide resolved
grpc-api/src/main/java/io/deephaven/grpc_api/session/SessionService.java
Outdated
Show resolved
Hide resolved
grpc-api/src/main/java/io/deephaven/grpc_api/session/SessionService.java
Outdated
Show resolved
Hide resolved
web/client-api/src/main/java/io/deephaven/web/client/api/WorkerConnection.java
Outdated
Show resolved
Hide resolved
web/client-api/src/main/java/io/deephaven/web/client/api/WorkerConnection.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Sep 7, 2021
web/client-api/src/main/java/io/deephaven/web/client/api/QueryConnectable.java
Show resolved
Hide resolved
nbauernfeind
force-pushed
the
fatal_err_interceptor
branch
from
83417bc to
444be40
Compare
rcaudy
reviewed
Sep 17, 2021
Member
rcaudy
left a comment
rcaudy
left a comment
There was a problem hiding this comment.
I looked at the changes in the last 7 commits for grpc_api classes. I assume Colin owns review for the rest. I have one suggestion, but otherwise this is ready to go.
grpc-api/src/main/java/io/deephaven/grpc_api/session/SessionService.java
Outdated
Show resolved
Hide resolved
Member
|
Generated JS is more or less ignored, as long as it doesn't break the build - that is the scaffolding such that the JS API could eventually call this api. |
niloc132
reviewed
Sep 17, 2021
grpc-api/src/main/java/io/deephaven/grpc_api/session/SessionService.java
Outdated
Show resolved
Hide resolved
grpc-api/src/main/java/io/deephaven/grpc_api/session/SessionService.java
Show resolved
Hide resolved
web/client-api/src/main/java/io/deephaven/web/client/api/WorkerConnection.java
Outdated
Show resolved
Hide resolved
web/client-api/src/main/java/io/deephaven/web/client/api/WorkerConnection.java
Outdated
Show resolved
Hide resolved
…mpt to notify on exit
nbauernfeind
force-pushed
the
fatal_err_interceptor
branch
from
d4af6c9 to
b7e73b1
Compare
niloc132
approved these changes
Sep 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is follow-up to improve experience in situations like #888, when the worker unexpectedly dies.
Clients subscribe to receive a terminal notification request when the process exits. Included in the message is the best level of detail we can offer describing the error that has just cropped up.
Initial integration with jsapi. The web-client-ui does not quite display this absolutely lovingly. However one can select-all and copy to bring the error to their favorite IDE for analysis.