Skip to content

Add java 22 nightly testing #5313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devinrsmith merged 3 commits into from
Apr 2, 2024
+17 −2
Merged

Add java 22 nightly testing #5313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91ef81c
Add Java 22 nighly testing
devinrsmith Apr 1, 2024
5cb0010
Bump groovy to 3.0.21, picks up asm 9.6 which can decode Java 22
devinrsmith Apr 1, 2024
091a561
Add test case for java 22
devinrsmith Apr 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/nightly-check-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
fail-fast: false
matrix:
gradle-task: ['check', 'testSerial', 'testParallel', 'testOutOfBand']
test-jvm-version: ['11', '17', '21']
test-jvm-version: ['11', '17', '21', '22']
if: ${{ github.repository_owner == 'deephaven' || github.event_name != 'schedule' }}
runs-on: ubuntu-22.04
concurrency:
Expand Down Expand Up @@ -48,6 +48,13 @@ jobs:
distribution: 'temurin'
java-version: '21'

- name: Setup JDK 22
id: setup-java-22
uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: '22'

- name: Set JAVA_HOME
run: echo "JAVA_HOME=${{ steps.setup-java-11.outputs.path }}" >> $GITHUB_ENV

Expand Down
8 changes: 8 additions & 0 deletions Configuration/src/test/java/io/deephaven/configuration/TestConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,6 +455,14 @@ public void testShowHistory() {
+
"java.base/java.lang.reflect.Method.invoke(Method.java:580)\n",
history.get(0).fileName);
} else if ("22".equals(javaVersion)) {
assertEquals(
"<not from configuration file>: io.deephaven.configuration.TestConfiguration.testShowHistory(TestConfiguration.java:428)\n"
+
"java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)\n"
+
"java.base/java.lang.reflect.Method.invoke(Method.java:580)\n",
history.get(0).fileName);
} else {
fail("Must add specific test for java version " + javaVersion);
}
Expand Down
2 changes: 1 addition & 1 deletion buildSrc/src/main/groovy/Classpaths.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ class Classpaths {
static final String LOGBACK_VERSION = '1.4.14'

static final String GROOVY_GROUP = 'org.codehaus.groovy'
static final String GROOVY_VERSION = '3.0.18'
static final String GROOVY_VERSION = '3.0.21'

static final String GRPC_GROUP = 'io.grpc'
static final String GRPC_NAME = 'grpc-bom'
Expand Down