Add period multiplication times longs#5635
Conversation
|
The feature was pulled from #5509 into a separate PR because of ongoing discussions at #5509 (comment). There are basically two camps.
|
|
I would also like to have it. I tested the original PR and lack of support for this surprised me. It would not surprise me if I was a Java guru, but I don't think that's the standard of surprise that users should be held to. IE, "it shouldn't surprise you because you should know what's going on" does not sound like a reasonable argument to me. |
rcaudy
left a comment
There was a problem hiding this comment.
We have no other methods that do this. Doing it here sets a bad precedent that we will hold the user's hand on this sort of type adjustment. It's simply not a good idea. If we do want something like this, do it within JPY for all long to int conversions.
I do not want to merge this.
There was a problem hiding this comment.
I'll say the same thing I did in the other review:
If users are frequently finding themselves with the issue "I've got a logical int-column, but the column type says it's a long" that's the root of the problem that we should address. Why is the column typed wider than the user expected / wanted?
Similarly for the request "I've got a BigInteger, why can't I use that to multiply a Period?", my argument against that would be the same as my argument against providing a long version.
|
I don't know if there would be any inherent advantage over a view formula, but being able to re-interpret a column from a long to an int (with strict safety checks) via |
|
#6110 can help convert |
Add period multiplication times longs.