feat: Support generic publish/fetch for plugins#5990
Merged
jmao-denver merged 9 commits intodeephaven:mainfrom Sep 23, 2024
Merged
feat: Support generic publish/fetch for plugins#5990jmao-denver merged 9 commits intodeephaven:mainfrom
jmao-denver merged 9 commits intodeephaven:mainfrom
Conversation
jmao-denver
added
DocumentationNeeded
ReleaseNotesNeeded
jmao-denver
force-pushed
the
5944-pyclient-share-any-export
branch
from
aa28a53 to
a6b5198
Compare
jmao-denver
changed the title
jmao-denver
force-pushed
the
5944-pyclient-share-any-export
branch
from
4e563ac to
d6668cc
Compare
niloc132
reviewed
Sep 13, 2024
Member
niloc132
left a comment
niloc132
left a comment
There was a problem hiding this comment.
My chief concerns here are that it might go too far in that it may break downstream code that uses some of these existing apis. If we're not bothered by that... perhaps it doesn't go far enough, and we should limit what kinds of tickets can be passed into what APIs, or what kinds of tickets are even possible to see in some cases.
chipkent
reviewed
Sep 17, 2024
rcaudy
reviewed
Sep 18, 2024
Member
rcaudy
left a comment
rcaudy
left a comment
There was a problem hiding this comment.
Please be sure to test end-to-end with Jupyter.
Co-authored-by: Chip Kent <5250374+chipkent@users.noreply.github.com>
Co-authored-by: Chip Kent <5250374+chipkent@users.noreply.github.com> Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
chipkent
reviewed
Sep 20, 2024
chipkent
approved these changes
Sep 23, 2024
Contributor
|
Labels indicate documentation is required. Issues for documentation have been opened: Community: deephaven/deephaven-docs-community#312 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5944