Skip to content

build(deps): DH-21987: upgrade Core cpp client deps (Arrow, gRPC, protobuf) on Windows#7814

Merged
jmao-denver merged 7 commits intodeephaven:mainfrom
jmao-denver:DH-21987-upgrade-core-cpp-client-deps
Mar 25, 2026
Merged

build(deps): DH-21987: upgrade Core cpp client deps (Arrow, gRPC, protobuf) on Windows#7814
jmao-denver merged 7 commits intodeephaven:mainfrom
jmao-denver:DH-21987-upgrade-core-cpp-client-deps

Conversation

@jmao-denver
Copy link
Contributor

@jmao-denver jmao-denver commented Mar 20, 2026

The bulk of the changes are due to that gpr_log is deprecated because gRPC decided to go with Abseil logging in versions 1.65+.

@jmao-denver jmao-denver self-assigned this Mar 20, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2026

No docs changes detected for 5b55617

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the C++ client’s pinned vcpkg dependency set (Arrow / gRPC / Protobuf / Abseil) and makes small source changes needed to build cleanly with the newer dependency stack.

Changes:

  • Bump vcpkg registry baseline and override versions for Arrow, gRPC, Protobuf, and Abseil.
  • Replace gpr_log usage with Abseil logging (LOG / VLOG) across the C++ client.
  • Add ElementRenderer support for char16_t / char32_t and apply Windows compile definitions (WIN32_LEAN_AND_MEAN, NOMINMAX).

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
cpp-client/deephaven/vcpkg.json Updates dependency overrides to newer Arrow/gRPC/Protobuf/Abseil versions.
cpp-client/deephaven/vcpkg-configuration.json Advances the vcpkg registry baseline commit.
cpp-client/deephaven/dhcore/include/public/deephaven/dhcore/utility/utility.h Adds rendering overloads for char16_t / char32_t to improve debug/stream output compatibility.
cpp-client/deephaven/dhclient/src/utility/executor.cc Migrates logging from gpr_log to Abseil LOG/VLOG.
cpp-client/deephaven/dhclient/src/subscription/subscribe_thread.cc Migrates logging from gpr_log to Abseil LOG.
cpp-client/deephaven/dhclient/src/server/server.cc Migrates logging from gpr_log to Abseil LOG/VLOG.
cpp-client/deephaven/dhclient/src/impl/table_handle_manager_impl.cc Migrates logging from gpr_log to Abseil VLOG.
cpp-client/deephaven/dhclient/src/impl/table_handle_impl.cc Migrates logging from gpr_log to Abseil LOG.
cpp-client/deephaven/dhclient/src/client.cc Migrates logging from gpr_log to Abseil LOG.
cpp-client/deephaven/dhclient/include/private/deephaven/client/server/server.h Removes now-unneeded grpc/support/log.h include.
cpp-client/deephaven/CMakeLists.txt Adds Windows-wide compile definitions to reduce header pollution and macro conflicts.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jmao-denver jmao-denver marked this pull request as ready for review March 20, 2026 18:58
@jcferretti
Copy link
Member

jcferretti commented Mar 20, 2026

We don't have CI to check that the iris dependencies (the C++ and R clients for Core+ in the enterprise repo) build and run correctly. We typically check that manually. I think we should do that.

@jcferretti
Copy link
Member

I don't see any changes for base images. Is the the idea is that we are going to only upgrade the windows dependencies (via vcpg) and leave the rest (eg, linux) as is?

@jmao-denver jmao-denver changed the title build(deps): DH-21987: upgrade Core cpp client deps (Arrow, gRPC, protobuf) build(deps): DH-21987: upgrade Core cpp client deps (Arrow, gRPC, protobuf) on Windows Mar 21, 2026
@jmao-denver
Copy link
Contributor Author

jmao-denver commented Mar 21, 2026

I don't see any changes for base images. Is the the idea is that we are going to only upgrade the windows dependencies (via vcpg) and leave the rest (eg, linux) as is?

My wrong assumption was that the Linux build made use of vcpkg repo as well. After our call, I think the consensus is that we better separate the two efforts. https://deephaven.atlassian.net/browse/DH-22059 is created to address the upgrade on Linux which might involve migrating the build workflow to one that uses vcpkg.

@jmao-denver jmao-denver marked this pull request as draft March 24, 2026 16:15
@jmao-denver jmao-denver force-pushed the DH-21987-upgrade-core-cpp-client-deps branch from 8677554 to 1a585e2 Compare March 25, 2026 02:38
@jmao-denver jmao-denver force-pushed the DH-21987-upgrade-core-cpp-client-deps branch from 1a585e2 to dd770a2 Compare March 25, 2026 03:25
@jmao-denver jmao-denver marked this pull request as ready for review March 25, 2026 15:47
@jmao-denver jmao-denver requested a review from kosak March 25, 2026 22:33
@jmao-denver jmao-denver merged commit 2061444 into deephaven:main Mar 25, 2026
24 checks passed
@jmao-denver jmao-denver deleted the DH-21987-upgrade-core-cpp-client-deps branch March 25, 2026 23:56
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants