Skip to content

Fix all Javadoc warnings#266

Merged
devinrsmith merged 2 commits intodeephaven:mainfrom
kosak:kosak_fix-javadoc
Sep 11, 2025
Merged

Fix all Javadoc warnings#266
devinrsmith merged 2 commits intodeephaven:mainfrom
kosak:kosak_fix-javadoc

Conversation

@kosak
Copy link
Contributor

@kosak kosak commented Sep 2, 2025

Addresses #6

This PR is basically comments-only plus a removal of a using and a rename of a parameter.

@kosak kosak self-assigned this Sep 2, 2025
@kosak kosak requested a review from devinrsmith September 2, 2025 02:16
@kosak kosak force-pushed the kosak_fix-javadoc branch from 4cf8785 to f963994 Compare September 7, 2025 16:51
@cpwright cpwright requested review from cpwright and removed request for devinrsmith September 8, 2025 14:15

/**
* The null value literal for specific columns, specified by 0-based column index. Specifying a null value
* literal for a column overrides the value in {@link #nullValueLiterals()}.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you do both a column and an index what happens?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented. PTAL

@devinrsmith devinrsmith merged commit a25594f into deephaven:main Sep 11, 2025
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2025
@kosak kosak deleted the kosak_fix-javadoc branch October 18, 2025 03:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants