feat: DH-21395: Add non-UTF-8, non-ASCII charset support#301
Merged
devinrsmith merged 9 commits intodeephaven:mainfrom Jan 14, 2026
Merged
feat: DH-21395: Add non-UTF-8, non-ASCII charset support#301devinrsmith merged 9 commits intodeephaven:mainfrom
devinrsmith merged 9 commits intodeephaven:mainfrom
Conversation
kosak
reviewed
Jan 13, 2026
src/main/java/io/deephaven/csv/reading/ReEncodingInputStream.java
Outdated
Show resolved
Hide resolved
src/test/java/io/deephaven/csv/reading/ReEncodingInputStreamTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/deephaven/csv/reading/ReEncodingInputStreamTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/deephaven/csv/reading/ReEncodingInputStreamTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/deephaven/csv/reading/ReEncodingInputStreamTest.java
Outdated
Show resolved
Hide resolved
devinrsmith
changed the title
kosak
approved these changes
Jan 14, 2026
Contributor
kosak
left a comment
kosak
left a comment
There was a problem hiding this comment.
LGTM - this looks lovely. Thank you for working on this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #300