feat: DH-21391: Add unit test that highlights edge cases of float vs double parsing#303
Merged
kosak merged 4 commits intodeephaven:mainfrom Jan 13, 2026
Merged
Conversation
kosak
force-pushed
the
kosak_parser-fidelity-test
branch
2 times, most recently
from
fc1f425 to
b751efa
Compare
kosak
force-pushed
the
kosak_parser-fidelity-test
branch
from
b751efa to
49108fa
Compare
devinrsmith
reviewed
Jan 13, 2026
src/test/java/io/deephaven/csv/testutil/ParserFidelityTest.java
Outdated
Show resolved
Hide resolved
devinrsmith
reviewed
Jan 13, 2026
src/test/java/io/deephaven/csv/testutil/ParserFidelityTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/deephaven/csv/testutil/ParserFidelityTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/deephaven/csv/testutil/ParserFidelityTest.java
Outdated
Show resolved
Hide resolved
lbooker42
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a subtle topic, but there are a a few edge cases where users will get slightly different floating point answers than expected when using our library. These all boil down to the same reasons:
There are cases where the Java expression
Float.parse(s)can differ from(float)Double.parse(s). We use (the equivalent of) the latter everywhere for type inferencing reasons and because our double parser is a third-party library that is very fast.We are already aware of this, and we provide
FloatStrictParserfor users that want strict behavior that is exactlyFloat.parse(s).This issue adds a unit test that exercises
FloatStrictParserand highlights its differences.