Skip to content

fix: check for ServiceWorker#42

Merged
jnumainville merged 1 commit intodeephaven:mainfrom
jnumainville:41_serviceworker
Jun 5, 2024
Merged

fix: check for ServiceWorker#42
jnumainville merged 1 commit intodeephaven:mainfrom
jnumainville:41_serviceworker

Conversation

@jnumainville
Copy link
Copy Markdown
Collaborator

fixes #41

@jnumainville jnumainville requested a review from mofojed June 5, 2024 19:20
@jnumainville jnumainville self-assigned this Jun 5, 2024
Copy link
Copy Markdown
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure you could just check ServiceWorker !== undefined, but this works too.

@jnumainville jnumainville merged commit 657b497 into deephaven:main Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ServiceWorker is not defined error

2 participants