Merged
Conversation
Collaborator
Author
|
Some examples: |
mofojed
requested changes
Oct 6, 2023
mofojed
approved these changes
Nov 1, 2023
Member
mofojed
left a comment
There was a problem hiding this comment.
Open a ticket for default colours of maps. Should tie in with the current theme.
Member
|
Ticket opened for default colours: deephaven/web-client-ui#1722 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29, closes #28, closes #27, closes #26, and closes #21
Adds basic capabilities for all maps with the exception of choropleth
I originally was trying to include choropleths as well but they're a bit more complicated and I already have spent a bit too long on this for the moment. The other maps are basically free to implement.
There is a graphical issue with density mapbox that would be good for @mattrunyon to look at when adding the defaults. The data is there but not being drawn.
Here's some code to recreate the issue:
I see a ton of errors in the console, some along the line of "The layer 'plotly-trace-layer-ea2295-heatmap' does not exist in the map's style and cannot be styled."
Additionally, geo plots have the snapping issue when dragging when new data loads in that 3d plots had. Using the same imports: