fix native layer concat bug. #3112
Merged
njzjz merged 4 commits intodeepmodeling:develfrom Jan 5, 2024
Merged
Conversation
for more information, see https://pre-commit.ci
Member
|
What is the expected input shape? |
njzjz
approved these changes
Jan 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #3112 +/- ##
=======================================
Coverage 75.86% 75.87%
=======================================
Files 247 247
Lines 25117 25117
Branches 1598 1598
=======================================
+ Hits 19055 19057 +2
+ Misses 5123 5121 -2
Partials 939 939 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
only the last dimension of the input is changed by the mlp. Do we add test of higher dimensional input like [xxx, yyy, ninp]? |
for more information, see https://pre-commit.ci
Collaborator
Author
done |
njzjz
approved these changes
Jan 5, 2024
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add UT testing all input and output shapes