Skip to content

dp: pt: rearrange folder structure of atomic_model and model.#3268

Merged
wanghan-iapcm merged 9 commits intodeepmodeling:develfrom
wanghan-iapcm:atomic-model-folder
Feb 15, 2024
Merged

dp: pt: rearrange folder structure of atomic_model and model.#3268
wanghan-iapcm merged 9 commits intodeepmodeling:develfrom
wanghan-iapcm:atomic-model-folder

Conversation

@wanghan-iapcm
Copy link
Copy Markdown
Collaborator

@wanghan-iapcm wanghan-iapcm commented Feb 13, 2024

  • create models dpmodel.atomic_model and pt.model.atomic_model.
  • place all the atomic model related codes into the new modules.
  • PairTabModel -> PairTabAtomicModel
  • ZBLModel -> DPZBLModel

Comment thread deepmd/dpmodel/atomic_model/__init__.py Fixed
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 13, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (25bf37a) 74.91% compared to head (3f51f0e) 74.81%.

Files Patch % Lines
deepmd/pt/model/model/dp_zbl_model.py 57.14% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3268      +/-   ##
==========================================
- Coverage   74.91%   74.81%   -0.11%     
==========================================
  Files         378      382       +4     
  Lines       33426    33419       -7     
  Branches     1600     1586      -14     
==========================================
- Hits        25041    25002      -39     
+ Misses       7514     7493      -21     
- Partials      871      924      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread deepmd/dpmodel/atomic_model/__init__.py
Comment thread deepmd/dpmodel/model/__init__.py
Comment thread deepmd/pt/model/atomic_model/pairtab_atomic_model.py
@anyangml
Copy link
Copy Markdown
Collaborator

LGTM

@wanghan-iapcm wanghan-iapcm merged commit aae4850 into deepmodeling:devel Feb 15, 2024
@wanghan-iapcm wanghan-iapcm deleted the atomic-model-folder branch February 15, 2024 08:16
@wanghan-iapcm wanghan-iapcm restored the atomic-model-folder branch February 15, 2024 17:07
@wanghan-iapcm wanghan-iapcm deleted the atomic-model-folder branch February 15, 2024 17:10
@njzjz njzjz mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants