fix neighbor stat mixed_types input#3304
Merged
njzjz merged 3 commits intodeepmodeling:develfrom Feb 20, 2024
Merged
Conversation
It was broken by deepmodeling#3289, which replaced distinguished types by mixed types but didn't change the input. Add tests for two types. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #3304 +/- ##
==========================================
- Coverage 75.05% 75.05% -0.01%
==========================================
Files 396 396
Lines 33895 33895
Branches 1604 1600 -4
==========================================
- Hits 25441 25440 -1
- Misses 7593 7594 +1
Partials 861 861 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was broken by #3289, which replaced distinguished types by mixed types but didn't change the input.
Add tests for two types.