Skip to content

consistent energy model#3306

Merged
wanghan-iapcm merged 8 commits intodeepmodeling:develfrom
njzjz:consistent-energy-model
Feb 21, 2024
Merged

consistent energy model#3306
wanghan-iapcm merged 8 commits intodeepmodeling:develfrom
njzjz:consistent-energy-model

Conversation

@njzjz
Copy link
Copy Markdown
Member

@njzjz njzjz commented Feb 20, 2024

Many hacking things...

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Comment thread deepmd/tf/model/model.py Fixed
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 20, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (8b1ed14) 75.29% compared to head (83fd5b2) 75.19%.
Report is 2 commits behind head on devel.

Files Patch % Lines
deepmd/tf/model/model.py 72.22% 10 Missing ⚠️
deepmd/tf/fit/fitting.py 72.22% 5 Missing ⚠️
deepmd/pt/utils/utils.py 66.66% 4 Missing ⚠️
deepmd/dpmodel/model/model.py 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3306      +/-   ##
==========================================
- Coverage   75.29%   75.19%   -0.10%     
==========================================
  Files         398      399       +1     
  Lines       33684    33740      +56     
  Branches     1604     1586      -18     
==========================================
+ Hits        25361    25371      +10     
+ Misses       7462     7454       -8     
- Partials      861      915      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz marked this pull request as draft February 20, 2024 01:21
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz marked this pull request as ready for review February 20, 2024 02:28
Comment thread deepmd/tf/model/model.py
Comment thread source/tests/consistent/model/common.py Outdated
Comment thread source/tests/consistent/model/test_ener.py Outdated
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz requested a review from wanghan-iapcm February 21, 2024 04:33
Comment thread deepmd/pt/utils/utils.py

@overload
def to_numpy_array(xx: torch.Tensor) -> np.ndarray:
...

Check notice

Code scanning / CodeQL

Statement has no effect

This statement has no effect.
Comment thread deepmd/pt/utils/utils.py

@overload
def to_numpy_array(xx: None) -> None:
...

Check notice

Code scanning / CodeQL

Statement has no effect

This statement has no effect.
Comment thread deepmd/pt/utils/utils.py

@overload
def to_torch_tensor(xx: np.ndarray) -> torch.Tensor:
...

Check notice

Code scanning / CodeQL

Statement has no effect

This statement has no effect.
Comment thread deepmd/pt/utils/utils.py

@overload
def to_torch_tensor(xx: None) -> None:
...

Check notice

Code scanning / CodeQL

Statement has no effect

This statement has no effect.
@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Feb 21, 2024
Merged via the queue into deepmodeling:devel with commit e1c0564 Feb 21, 2024
@njzjz njzjz mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants