Skip to content

pt: export model_output_type instead of model_output_def#3318

Merged
wanghan-iapcm merged 4 commits intodeepmodeling:develfrom
njzjz:model-output-def
Feb 23, 2024
Merged

pt: export model_output_type instead of model_output_def#3318
wanghan-iapcm merged 4 commits intodeepmodeling:develfrom
njzjz:model-output-def

Conversation

@njzjz
Copy link
Copy Markdown
Member

@njzjz njzjz commented Feb 22, 2024

Fix #3317.

Fix deepmodeling#3317.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz requested a review from wanghan-iapcm February 22, 2024 02:19
@njzjz njzjz linked an issue Feb 22, 2024 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 56.66667% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 75.29%. Comparing base (cf21b7a) to head (d251727).

Files Patch % Lines
deepmd/dpmodel/model/make_model.py 11.11% 8 Missing ⚠️
deepmd/pt/infer/deep_eval.py 28.57% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #3318   +/-   ##
=======================================
  Coverage   75.28%   75.29%           
=======================================
  Files         403      403           
  Lines       33888    33909   +21     
  Branches     1604     1604           
=======================================
+ Hits        25514    25531   +17     
- Misses       7513     7517    +4     
  Partials      861      861           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread deepmd/dpmodel/model/make_model.py
Comment thread deepmd/dpmodel/model/make_model.py Outdated
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz requested a review from wanghan-iapcm February 22, 2024 21:25
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Feb 23, 2024
Merged via the queue into deepmodeling:devel with commit 6345207 Feb 23, 2024
@njzjz njzjz mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] pt: loading TorchScript model failed

2 participants