feat: convert model files between backends#3323
Merged
wanghan-iapcm merged 11 commits intodeepmodeling:develfrom Feb 23, 2024
Merged
feat: convert model files between backends#3323wanghan-iapcm merged 11 commits intodeepmodeling:develfrom
wanghan-iapcm merged 11 commits intodeepmodeling:develfrom
Conversation
Member
njzjz
commented
Feb 22, 2024
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #3323 +/- ##
==========================================
+ Coverage 75.28% 75.33% +0.04%
==========================================
Files 403 406 +3
Lines 33888 34025 +137
Branches 1604 1604
==========================================
+ Hits 25514 25632 +118
- Misses 7513 7532 +19
Partials 861 861 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Collaborator
wanghan-iapcm
left a comment
There was a problem hiding this comment.
model_param may be confused with the trainable model parameters. I would suggest using more self-explanatory names like model_def_script.
iProzd
approved these changes
Feb 22, 2024
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
wanghan-iapcm
approved these changes
Feb 23, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.