Skip to content

Feat: add polar consistency test#3327

Merged
wanghan-iapcm merged 38 commits intodeepmodeling:develfrom
anyangml:feat/polar_consistency_test
Feb 23, 2024
Merged

Feat: add polar consistency test#3327
wanghan-iapcm merged 38 commits intodeepmodeling:develfrom
anyangml:feat/polar_consistency_test

Conversation

@anyangml
Copy link
Copy Markdown
Collaborator

@anyangml anyangml commented Feb 23, 2024

This PR is to add cross framework consistency test on PolarFittingNet.

Note: shift_diag not yet implemented in PT.

anyangml and others added 30 commits February 22, 2024 11:42
@anyangml anyangml marked this pull request as draft February 23, 2024 04:35
anyangml and others added 3 commits February 23, 2024 14:01
Comment thread source/tests/consistent/fitting/test_polar.py
@property
def skip_pt(self) -> bool:
(
resnet_dt,

Check notice

Code scanning / CodeQL

Unused local variable

Variable resnet_dt is not used.
def skip_pt(self) -> bool:
(
resnet_dt,
precision,

Check notice

Code scanning / CodeQL

Unused local variable

Variable precision is not used.
(
resnet_dt,
precision,
mixed_types,

Check notice

Code scanning / CodeQL

Unused local variable

Variable mixed_types is not used.

def build_tf(self, obj: Any, suffix: str) -> Tuple[list, dict]:
(
resnet_dt,

Check notice

Code scanning / CodeQL

Unused local variable

Variable resnet_dt is not used.
def build_tf(self, obj: Any, suffix: str) -> Tuple[list, dict]:
(
resnet_dt,
precision,

Check notice

Code scanning / CodeQL

Unused local variable

Variable precision is not used.
def eval_pt(self, pt_obj: Any) -> Any:
(
resnet_dt,
precision,

Check notice

Code scanning / CodeQL

Unused local variable

Variable precision is not used.
(
resnet_dt,
precision,
mixed_types,

Check notice

Code scanning / CodeQL

Unused local variable

Variable mixed_types is not used.

def eval_dp(self, dp_obj: Any) -> Any:
(
resnet_dt,

Check notice

Code scanning / CodeQL

Unused local variable

Variable resnet_dt is not used.
def eval_dp(self, dp_obj: Any) -> Any:
(
resnet_dt,
precision,

Check notice

Code scanning / CodeQL

Unused local variable

Variable precision is not used.
(
resnet_dt,
precision,
mixed_types,

Check notice

Code scanning / CodeQL

Unused local variable

Variable mixed_types is not used.
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 75.38%. Comparing base (260ef21) to head (f389f73).

Files Patch % Lines
deepmd/dpmodel/fitting/polarizability_fitting.py 60.00% 2 Missing ⚠️
deepmd/pt/model/task/polarizability.py 80.00% 1 Missing ⚠️
deepmd/tf/fit/polar.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3327      +/-   ##
==========================================
+ Coverage   75.35%   75.38%   +0.03%     
==========================================
  Files         406      406              
  Lines       34059    34079      +20     
  Branches     1604     1604              
==========================================
+ Hits        25665    25692      +27     
+ Misses       7533     7526       -7     
  Partials      861      861              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anyangml anyangml marked this pull request as ready for review February 23, 2024 06:27
@anyangml anyangml self-assigned this Feb 23, 2024
@anyangml anyangml added the Test CUDA Trigger test CUDA workflow label Feb 23, 2024
@github-actions github-actions Bot removed the Test CUDA Trigger test CUDA workflow label Feb 23, 2024
Comment thread deepmd/utils/argcheck.py Outdated
@anyangml anyangml requested a review from njzjz February 23, 2024 08:43
@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Feb 23, 2024
Merged via the queue into deepmodeling:devel with commit 543276a Feb 23, 2024
@njzjz njzjz mentioned this pull request Apr 2, 2024
@anyangml anyangml deleted the feat/polar_consistency_test branch March 24, 2026 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants