pt: remove env.DEVICE in all forward functions#3330
Merged
njzjz merged 3 commits intodeepmodeling:develfrom Feb 26, 2024
Merged
pt: remove env.DEVICE in all forward functions#3330njzjz merged 3 commits intodeepmodeling:develfrom
forward functions#3330njzjz merged 3 commits intodeepmodeling:develfrom
Conversation
Ensure the saved model can run on both CPUs and GPUs. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
njzjz
requested review from
CaRoLZhangxy,
anyangml,
caic99,
iProzd and
wanghan-iapcm
caic99
approved these changes
Feb 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #3330 +/- ##
==========================================
+ Coverage 75.41% 75.52% +0.11%
==========================================
Files 406 408 +2
Lines 34106 34277 +171
Branches 1604 1600 -4
==========================================
+ Hits 25720 25888 +168
- Misses 7525 7528 +3
Partials 861 861 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Chun Cai <amoycaic@gmail.com> Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
wanghan-iapcm
approved these changes
Feb 24, 2024
iProzd
approved these changes
Feb 24, 2024
CaRoLZhangxy
approved these changes
Feb 25, 2024
anyangml
approved these changes
Feb 26, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure the saved JIT model can run on both CPUs and GPUs.