refact: pt: mv all plugin support to base descriptor. #3340
Merged
wanghan-iapcm merged 2 commits intodeepmodeling:develfrom Feb 27, 2024
Merged
refact: pt: mv all plugin support to base descriptor. #3340wanghan-iapcm merged 2 commits intodeepmodeling:develfrom
wanghan-iapcm merged 2 commits intodeepmodeling:develfrom
Conversation
wanghan-iapcm
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #3340 +/- ##
==========================================
+ Coverage 75.52% 75.53% +0.01%
==========================================
Files 408 408
Lines 34277 34223 -54
Branches 1604 1604
==========================================
- Hits 25888 25851 -37
+ Misses 7528 7511 -17
Partials 861 861 ☔ View full report in Codecov by Sentry. |
njzjz
reviewed
Feb 26, 2024
njzjz
approved these changes
Feb 26, 2024
njzjz
reviewed
Feb 26, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thus pt reusing the dp code.