throw errros if rmin is no less than rmax#3393
Merged
njzjz merged 9 commits intodeepmodeling:develfrom Mar 5, 2024
Merged
Conversation
when rmin==rmax, the previous implementation of compute_smooth_weight will give all nan. In theory, it should not happen. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #3393 +/- ##
==========================================
- Coverage 76.94% 76.91% -0.03%
==========================================
Files 423 423
Lines 35874 35878 +4
Branches 1620 1620
==========================================
- Hits 27604 27597 -7
- Misses 7402 7413 +11
Partials 868 868 ☔ View full report in Codecov by Sentry. |
njzjz
changed the title
wanghan-iapcm
approved these changes
Mar 5, 2024
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Collaborator
|
should be fixed by #3413 |
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when rmin==rmax, the previous implementation of compute_smooth_weight will give all nan. In theory, it should not happen.