pt: Fix compilation with libtorch#3405
Merged
wanghan-iapcm merged 2 commits intodeepmodeling:develfrom Mar 4, 2024
Merged
Conversation
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #3405 +/- ##
==========================================
- Coverage 76.98% 76.93% -0.06%
==========================================
Files 390 423 +33
Lines 31048 35847 +4799
Branches 909 1620 +711
==========================================
+ Hits 23903 27579 +3676
- Misses 6617 7400 +783
- Partials 528 868 +340 ☔ View full report in Codecov by Sentry. |
wanghan-iapcm
approved these changes
Mar 4, 2024
njzjz
added a commit
to njzjz/deepmd-kit
that referenced
this pull request
Mar 6, 2024
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu> deepmodeling#3405 changed results from `None` to `{}` but `print_on_training` wasn't revised.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 8, 2024
#3405 changed results from `None` to `{}` but `print_on_training` wasn't revised.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backported from conda-forge/deepmd-kit-feedstock#71.
INSTALL_RPATH_USE_LINK_PATHtotrueresolves the problem.${TORCH_CXX_FLAGS}is empty in macOS, so the variable with quotes, i.e."${TORCH_CXX_FLAGS}", should be used.