pt: avoid D2H in se_e2_a#3424
Merged
wanghan-iapcm merged 1 commit intodeepmodeling:develfrom Mar 6, 2024
Merged
Conversation
sec is used as slice index, so it should not stored on the GPU, otherwise D2H will happen to create the tensor with the shape. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #3424 +/- ##
=======================================
Coverage 76.95% 76.95%
=======================================
Files 423 423
Lines 35883 35883
Branches 1620 1621 +1
=======================================
Hits 27612 27612
Misses 7403 7403
Partials 868 868 ☔ View full report in Codecov by Sentry. |
wanghan-iapcm
approved these changes
Mar 6, 2024
Collaborator
wanghan-iapcm
left a comment
wanghan-iapcm
left a comment
There was a problem hiding this comment.
That's surprising...
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sec is used as a slice index, so it should not stored on the GPU, otherwise, D2H will happen to create the tensor with the shape.
Before:
After:
